[ a / b / cf / cy / g / lain ] [ fresh / meta ] [ home / rules / faq / affiliates ]

/g/ - Technology

Programming and Electronics
Name
Subject
Comment
File
Embed
Password (For file deletion.)

Hop in to our IRC channel! #wirechan@rizon.net

File: 1598810274591.jpg (321.89 KB, 1280x720, code review with the girls.jpg)

 No.366

What do you look for in a code review?

To be honest I just try to understand the code and the changes, which means that most of the time I point out things that hinder comprehension, like misleading variable names, overly complex approaches, and sometimes bugs in the logic or missing corner cases. But I feel like most of my comments are just nitpicking and I am wasting everyone's time.

 No.367

As an aside, I looked up the topic on the c2 wiki and it's full of advice for code reviews… where you print out the code under review and go through it during a meeting…

 No.368

>>366

I tend to "nitpick" also, mainly because no one else seemingly gives a damn about the code they write. I'm only a junior programmer, but I constantly have to correct the lazy coding styles of the seniors. I put a lot of effort into writing clean and understandable code, but when it's not reciprocated, it feels like my hard work was for nothing.

 No.369

>What is job security?

 No.371

>>368
>>369
complacency kills, but at the same time not everything has to be a labor of love. if i'm not getting premium pay i don't generally put out a premium product.
if it's my own project it's a different story though

 No.372

>>368
Do you have a linter hooked up with whatever your team uses for code reviews? If not, do everything you can to get one, it makes everyone's life much easier. But yeah, that sounds miserable.

 No.376

File: 1599173287430.jpg (390.43 KB, 1024x783, reviewing.jpg)

>>371
Yeah no I agree with you. I think I perceive it this way since I'm only at the starting phase of my career and lack the exposure. I know that most pragmatic approach is to save my autism for my personal programming projects, rather than being a nuisance to everyone at work.

>>372
We do actually, but it mostly cleans up formatting errors and gives some warnings about unused variables and such. Not really that helpful. I mostly have a problem with their portrayed disinterest for structure and cleanliness. I perceive their mentality to be something along the lines of: "My first attempt did what it was supposed to, so why take a moment to consider it and possibly iterate it one more time.". That being said I realize that you have to draw the line somewhere. You probably get my point.

That's enough about my complaints. Reiterating OP's question: What do you look for in reviews?

 No.379

>>366
In my last job, I was as picky as you, OP. But when it came to fixing all the findings, we were told to only fix potential bugs, and leave all the violations of the coding style guide in place. I especially hated it, when people write code, that doesn't even fit on a full HD screen with a small font. Like what were they thinking? I would be ashamed to deliver such code. The real fun begins when you try to do diffs side by side with such a mess.

I also felt like i was too picky all the time, because nobody else seemed to care, but on the other hand, this software was low-level code for devices peoples lifes depend on.

You probably don't want to know what shitty code is inside health devices like pacemakers or insuline pumps and what not.



[Return][Go to top] [Catalog] [Post a Reply]
Delete Post [ ]
[ a / b / cf / cy / g / lain ] [ fresh / meta ] [ home / rules / faq / affiliates ]